Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319650: Improve heap dump performance with class metadata caching #388

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 21, 2023

Unclean backport to improve heap dump performance. The uncleanliness comes from JDK-8306441 that does not exist in JDK 21, and which I don't think we want to backport at the moment. I had to add a few more ResourceMark-s near HeapDumpWriter to manage the cache allocations.

Additional testing:

  • MacOS AArch64 server release, heap dump performance improved
  • Linux x86_64 server fastdebug, serviceability/ (contains heap dump tests)
  • Linux x86_64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests)
  • Linux x86_64 server fastdebug, gc/epsilon (contains heap dump on failure tests)
  • Linux x86_64 server fastdebug, sun/tools/jhsdb (contains heap dump tests)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8319650 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8319650: Improve heap dump performance with class metadata caching (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/388/head:pull/388
$ git checkout pull/388

Update a local copy of the PR:
$ git checkout pull/388
$ git pull https://git.openjdk.org/jdk21u.git pull/388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 388

View PR using the GUI difftool:
$ git pr show -t 388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/388.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03db82818b905f21cb5ad1d56a687e238b4a6e33 8319650: Improve heap dump performance with class metadata caching Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 21, 2023
@shipilev shipilev marked this pull request as ready for review November 22, 2023 18:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Unclean backport to improve heap dump performance. Tests pass. 21u RFR acked by Paul Hohensee.

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

@shipilev
8319650: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 24, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319650: Improve heap dump performance with class metadata caching

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • f01df29: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • afc506e: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
  • 3df010f: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
  • ecb199a: 8313616: support loading library members on AIX in os::dll_load
  • 220b36c: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • d7a3ac7: 8318587: refresh libraries cache on AIX in print_vm_info
  • 0941f2c: 8318562: Computational test more than 2x slower when AVX instructions are used
  • e7bd0ab: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 21a003a: 8320209: VectorMaskGen clobbers rflags on x86_64
  • 689b90d: 8318957: enhance agentlib:jdwp help output by info about allow option
  • ... and 49 more: https://git.openjdk.org/jdk21u/compare/37888d29125e2ac818600543eb065ea5bf01897e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 27, 2023
@shipilev
Copy link
Member Author

Closing in favor of openjdk/jdk21u-dev#8

@shipilev shipilev closed this Dec 13, 2023
@shipilev shipilev deleted the JDK-8319650-heapdump-cache-class branch December 13, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants