Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315936: Parallelize gc/stress/TestStressG1Humongous.java test #389

Closed

Conversation

ianrichr
Copy link

@ianrichr ianrichr commented Nov 21, 2023

Hi all,

This pull request contains a backport of commit [3f19df68](https://github.com/openjdk/jdk/commit/3f19df685c342cef212305cca630331878a24e79) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Ian Myers on 28 Sep 2023 and was reviewed by Aleksey Shipilev and Thomas Schatzl.

Thanks!

Progress

  • JDK-8315936 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315936: Parallelize gc/stress/TestStressG1Humongous.java test (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/389/head:pull/389
$ git checkout pull/389

Update a local copy of the PR:
$ git checkout pull/389
$ git pull https://git.openjdk.org/jdk21u.git pull/389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 389

View PR using the GUI difftool:
$ git pr show -t 389

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/389.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back imyers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f19df685c342cef212305cca630331878a24e79 8315936: Parallelize gc/stress/TestStressG1Humongous.java test Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

⚠️ @ianrichr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2023

Webrevs

@ianrichr
Copy link
Author

/approval request Clean backport to improve testing. Applies cleanly.

@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@ianrichr
8315936: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@ianrichr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315936: Parallelize gc/stress/TestStressG1Humongous.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 593ef7c: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
  • 0f7bbe1: 8318895: Deoptimization results in incorrect lightweight locking stack
  • cae6460: 8318078: ADLC: pass ASSERT and PRODUCT flags
  • 19ce3ec: 8319120: Unbound ScopedValue.get() throws the wrong exception
  • f5045fc: 8319195: Move most tier 1 vector API regression tests to tier 3
  • e86ae80: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 4d5ceb4: 8316581: Improve performance of Symbol::print_value_on()
  • 1326d00: 8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class
  • 1f7b17d: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 4022eac: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • ... and 7 more: https://git.openjdk.org/jdk21u/compare/0941f2ce67d29f36433772f6e64e8a87071ae607...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 27, 2023
@ianrichr
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@ianrichr
Your change (at version 931f1bb) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

Going to push as commit 2e55190.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 593ef7c: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
  • 0f7bbe1: 8318895: Deoptimization results in incorrect lightweight locking stack
  • cae6460: 8318078: ADLC: pass ASSERT and PRODUCT flags
  • 19ce3ec: 8319120: Unbound ScopedValue.get() throws the wrong exception
  • f5045fc: 8319195: Move most tier 1 vector API regression tests to tier 3
  • e86ae80: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 4d5ceb4: 8316581: Improve performance of Symbol::print_value_on()
  • 1326d00: 8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class
  • 1f7b17d: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 4022eac: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • ... and 7 more: https://git.openjdk.org/jdk21u/compare/0941f2ce67d29f36433772f6e64e8a87071ae607...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2023
@openjdk openjdk bot closed this Nov 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@shipilev @ianrichr Pushed as commit 2e55190.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants