Skip to content

8319120: Unbound ScopedValue.get() throws the wrong exception #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 22, 2023

Clean backport to fix a preview feature.

Additional testing:

  • MacOS AArch64 server fastdebug, new regression test fails without the fix, passes with it
  • MacOS AArch64 server fastdebug, java/lang/ScopedValue passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319120 needs maintainer approval

Issue

  • JDK-8319120: Unbound ScopedValue.get() throws the wrong exception (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/392/head:pull/392
$ git checkout pull/392

Update a local copy of the PR:
$ git checkout pull/392
$ git pull https://git.openjdk.org/jdk21u.git pull/392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 392

View PR using the GUI difftool:
$ git pr show -t 392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/392.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

/approval request Clean backport to fix a preview feature. Applies cleanly. Tests passes. New regression test works.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ee6f25b5072a26254f79381a92216357d9f391f9 8319120: Unbound ScopedValue.get() throws the wrong exception Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@shipilev
8319120: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 22, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319120: Unbound ScopedValue.get() throws the wrong exception

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • f01df29: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • afc506e: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
  • 3df010f: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
  • ecb199a: 8313616: support loading library members on AIX in os::dll_load
  • 220b36c: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • d7a3ac7: 8318587: refresh libraries cache on AIX in print_vm_info
  • 0941f2c: 8318562: Computational test more than 2x slower when AVX instructions are used
  • e7bd0ab: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 21a003a: 8320209: VectorMaskGen clobbers rflags on x86_64
  • 689b90d: 8318957: enhance agentlib:jdwp help output by info about allow option
  • ... and 49 more: https://git.openjdk.org/jdk21u/compare/37888d29125e2ac818600543eb065ea5bf01897e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 27, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

Going to push as commit 19ce3ec.
Since your change was applied there have been 66 commits pushed to the master branch:

  • f5045fc: 8319195: Move most tier 1 vector API regression tests to tier 3
  • e86ae80: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 4d5ceb4: 8316581: Improve performance of Symbol::print_value_on()
  • 1326d00: 8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class
  • 1f7b17d: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 4022eac: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • b42280b: 8318144: Match on enum constants with body compiles but fails with MatchException
  • f01df29: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • afc506e: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
  • 3df010f: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
  • ... and 56 more: https://git.openjdk.org/jdk21u/compare/37888d29125e2ac818600543eb065ea5bf01897e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2023
@openjdk openjdk bot closed this Nov 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@shipilev Pushed as commit 19ce3ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8319120-scopedvalue-get-exception branch November 28, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant