Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319700: [AArch64] C2 compilation fails with "Field too big for insn" #398

Closed
wants to merge 1 commit into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Nov 23, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319700 needs maintainer approval

Issue

  • JDK-8319700: [AArch64] C2 compilation fails with "Field too big for insn" (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/398/head:pull/398
$ git checkout pull/398

Update a local copy of the PR:
$ git checkout pull/398
$ git pull https://git.openjdk.org/jdk21u.git pull/398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 398

View PR using the GUI difftool:
$ git pr show -t 398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/398.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2023

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3787ff8d1d8dbcaaebb9616c5bc543e2fe21a90c 8319700: [AArch64] C2 compilation fails with "Field too big for insn" Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

⚠️ @xmas92 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2023
@xmas92
Copy link
Member Author

xmas92 commented Nov 23, 2023

/approval request Bugs needs fixing in 21 as well.

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@xmas92
8319700: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 23, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319700: [AArch64] C2 compilation fails with "Field too big for insn"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ecb199a: 8313616: support loading library members on AIX in os::dll_load

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 24, 2023
@xmas92
Copy link
Member Author

xmas92 commented Nov 26, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 26, 2023
@openjdk
Copy link

openjdk bot commented Nov 26, 2023

@xmas92
Your change (at version 8ac4cfe) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

Going to push as commit afc506e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3df010f: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
  • ecb199a: 8313616: support loading library members on AIX in os::dll_load

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2023
@openjdk openjdk bot closed this Nov 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@shipilev @xmas92 Pushed as commit afc506e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants