Skip to content

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 4, 2023

Backport of JDK-8312909. Applies cleanly.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312909: C1 should not inline through interface calls with non-subtype receiver (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.org/jdk21u.git pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/40.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ab1c212ac1097ae6e1122ef1aba47ca51eca11f2 8312909: C1 should not inline through interface calls with non-subtype receiver Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312909: C1 should not inline through interface calls with non-subtype receiver

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 8, 2023

Going to push as commit 7350b3f.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 515387d: 8304954: SegmentedCodeCache fails when using large pages
  • a21ad55: 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1
  • aafd687: Merge
  • bfe037a: 8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023
  • 4273487: 8313593: Generational ZGC: NMT assert when the heap fails to expand
  • fd789db: 8312572: JDK 21 RDP2 L10n resource files update
  • 46dd733: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout
  • f532042: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 610812d: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [i4] but found [I4]
  • f87a70d: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/90249f0add935bcfae5cc0fe648cce60d29c36ad...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2023
@openjdk openjdk bot closed this Aug 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@TobiHartmann Pushed as commit 7350b3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant