Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity #403

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Nov 24, 2023

Clean backport of JDK-8320363.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320363 needs maintainer approval

Issue

  • JDK-8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/403/head:pull/403
$ git checkout pull/403

Update a local copy of the PR:
$ git checkout pull/403
$ git pull https://git.openjdk.org/jdk21u.git pull/403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 403

View PR using the GUI difftool:
$ git pr show -t 403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/403.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6aa197667ad05bd93adf3afc7b06adbfb2b18a22 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity Nov 24, 2023
@openjdk
Copy link

openjdk bot commented Nov 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Small, but obvious bug in type profiling on PPC64. Doesn't cause crashes, but unnecessary profile updates. Fix only touches PPC64 files, is very small and applies cleanly. Tested in jdk head and this PR in our nightly tests.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@TheRealMDoerr
8320363: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 4022eac: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • b42280b: 8318144: Match on enum constants with body compiles but fails with MatchException
  • f01df29: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • afc506e: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
  • 3df010f: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 27, 2023
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

Going to push as commit f8706d1.
Since your change was applied there have been 16 commits pushed to the master branch:

  • f3ff69a: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
  • 2e55190: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 593ef7c: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
  • 0f7bbe1: 8318895: Deoptimization results in incorrect lightweight locking stack
  • cae6460: 8318078: ADLC: pass ASSERT and PRODUCT flags
  • 19ce3ec: 8319120: Unbound ScopedValue.get() throws the wrong exception
  • f5045fc: 8319195: Move most tier 1 vector API regression tests to tier 3
  • e86ae80: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 4d5ceb4: 8316581: Improve performance of Symbol::print_value_on()
  • 1326d00: 8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class
  • ... and 6 more: https://git.openjdk.org/jdk21u/compare/ecb199ad285fd13d257aa9629609728052abe742...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2023
@openjdk openjdk bot closed this Nov 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@TheRealMDoerr Pushed as commit f8706d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant