Skip to content

Conversation

@ArsenyBochkarev
Copy link

@ArsenyBochkarev ArsenyBochkarev commented Nov 25, 2023

Fix for initial implementation of _poly1305_processBlocks. JBS issue: https://bugs.openjdk.org/browse/JDK-8320564


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320564 needs maintainer approval

Integration blocker

 ⚠️ Dependency #390 must be integrated first

Issue

  • JDK-8320564: RISC-V: Minimal build failed after JDK-8316592 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/404/head:pull/404
$ git checkout pull/404

Update a local copy of the PR:
$ git checkout pull/404
$ git pull https://git.openjdk.org/jdk21u.git pull/404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 404

View PR using the GUI difftool:
$ git pr show -t 404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/404.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2023

👋 Welcome back ArsenyBochkarev! A progress list of the required criteria for merging this PR into pr/390 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 864b39a89398731bfde9af10c3d7797ff5d05760 8320564: RISC-V: Minimal build failed after JDK-8316592 Nov 25, 2023
@openjdk
Copy link

openjdk bot commented Nov 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Nov 25, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2023

Webrevs

@ArsenyBochkarev
Copy link
Author

/approval request

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@ArsenyBochkarev
8320564: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 28, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

Please move this PR to jdk21u-dev and when re-applying for approval provide a non-empty approval request comment using:

  /approval request <your-comment>

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@jerboaa Only the author (@ArsenyBochkarev) is allowed to issue the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants