Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all #405

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 27, 2023

Hi all,

This pull request contains a backport of JDK-8320601, commit f6e5559a from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 27 Nov 2023 and was reviewed by Matthias Baesken.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320601 needs maintainer approval

Issue

  • JDK-8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/405/head:pull/405
$ git checkout pull/405

Update a local copy of the PR:
$ git checkout pull/405
$ git pull https://git.openjdk.org/jdk21u.git pull/405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 405

View PR using the GUI difftool:
$ git pr show -t 405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/405.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f6e5559ae9d1c8b84b31af5d36e93b43e7731ba5 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/approval request Requesting backport of this exclusion list modification. No risk.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@RealCLanger
8320601: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 4022eac: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • b42280b: 8318144: Match on enum constants with body compiles but fails with MatchException
  • f01df29: 8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • afc506e: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 27, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit ab7380e.
Since your change was applied there have been 16 commits pushed to the master branch:

  • f8706d1: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
  • f3ff69a: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
  • 2e55190: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 593ef7c: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
  • 0f7bbe1: 8318895: Deoptimization results in incorrect lightweight locking stack
  • cae6460: 8318078: ADLC: pass ASSERT and PRODUCT flags
  • 19ce3ec: 8319120: Unbound ScopedValue.get() throws the wrong exception
  • f5045fc: 8319195: Move most tier 1 vector API regression tests to tier 3
  • e86ae80: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 4d5ceb4: 8316581: Improve performance of Symbol::print_value_on()
  • ... and 6 more: https://git.openjdk.org/jdk21u/compare/3df010f444428ecc5ac1efae569dd92134bdf207...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@RealCLanger Pushed as commit ab7380e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant