Skip to content

8316229: Enhance class initialization logging #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 27, 2023

Clean backport to improve JVM diagnostics. There is no bugtail recorded after few months in mainline.

Additional testing:

  • MacOS AArch64 fastdebug, hotspot:tier1.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316229 needs maintainer approval

Issue

  • JDK-8316229: Enhance class initialization logging (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/406/head:pull/406
$ git checkout pull/406

Update a local copy of the PR:
$ git checkout pull/406
$ git pull https://git.openjdk.org/jdk21u.git pull/406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 406

View PR using the GUI difftool:
$ git pr show -t 406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/406.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84124794c2ff70ba22cbfbf1ff01cf4d935896bd 8316229: Enhance class initialization logging Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2023
@shipilev
Copy link
Member Author

/approval request Clean backport to improve JVM diagnostics. There is no bugtail recorded after few months in mainline.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@shipilev
8316229: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

@shipilev
Copy link
Member Author

Closing in favor of openjdk/jdk21u-dev#7

@shipilev shipilev closed this Dec 13, 2023
@shipilev shipilev deleted the JDK-8316229-class-init-logging branch December 13, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant