Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX #407

Closed
wants to merge 1 commit into from

Conversation

JoKern65
Copy link

@JoKern65 JoKern65 commented Nov 28, 2023

We should not mix os::dll_load() with dlclose(), but should call os::dll_unload(). At the moment this is benign, but this prevents certain type of platforms specific workarounds inside os::dll_load() and is a prerequisite for these upcoming changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319633 needs maintainer approval

Issue

  • JDK-8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/407/head:pull/407
$ git checkout pull/407

Update a local copy of the PR:
$ git checkout pull/407
$ git pull https://git.openjdk.org/jdk21u.git pull/407/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 407

View PR using the GUI difftool:
$ git pr show -t 407

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/407.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2023

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 464dc3dab540a36aeea76dbeea548c600df58763 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

⚠️ @JoKern65 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

⚠️ @JoKern65 a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master ab7380e2d9d3c340120bf9c41029c334c809291e
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2023

Webrevs

@JoKern65
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@JoKern65 usage: /approval [<id>] (request|cancel) [<text>]

@JoKern65
Copy link
Author

/approval JDK-8319633 request Backport of test fix for AIX. No risk, clean backport.

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@JoKern65
JDK-8319633: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 28, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

@JoKern65 Please move this PR to jdk21u-dev. When doing so enable GHA checks on your fork, please.

@openjdk openjdk bot removed the approval label Dec 14, 2023
@JoKern65 JoKern65 closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
2 participants