Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms #408

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 29, 2023


Progress

  • Change must not contain extraneous whitespace
  • JDK-8320898 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/408/head:pull/408
$ git checkout pull/408

Update a local copy of the PR:
$ git checkout pull/408
$ git pull https://git.openjdk.org/jdk21u.git pull/408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 408

View PR using the GUI difftool:
$ git pr show -t 408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/408.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 78b6c2b40885529adb2627e004317466b2c03868 8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 29, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

@MBaesken Please move this PR to jdk21u-dev and apply again for approval.

@openjdk openjdk bot added approval and removed approval labels Dec 14, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

Please close this PR.

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 60b6a66: 8320597: RSA signature verification fails on signed data that does not encode params correctly
  • ba79073: 8321067: Unlock experimental options in EATests.java
  • 7592983: 8320001: javac crashes while adding type annotations to the return type of a constructor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 14, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

@MBaesken This PR needs to get closed and https://git.openjdk.org/jdk21u-dev/pull/27 integrated instead.

@MBaesken MBaesken closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants