Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows #416

Closed
wants to merge 1 commit into from

Conversation

yukikimmura
Copy link

@yukikimmura yukikimmura commented Dec 4, 2023

I would like to backport JDK-8318410 to 21u because the test dose not work as intended.
The fix applies cleanly to 21u.
I tested BootClassPathTest on Windows(English,Japanese) and Linux(locales used in the test with LANG/LC_ALL/LC_CTYPE).

Could someone please review it?

Thanks,
Kimura Yukihiro


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318410 needs maintainer approval

Issue

  • JDK-8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/416/head:pull/416
$ git checkout pull/416

Update a local copy of the PR:
$ git checkout pull/416
$ git pull https://git.openjdk.org/jdk21u.git pull/416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 416

View PR using the GUI difftool:
$ git pr show -t 416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/416.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2023

👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d051f22284e7ccc288c658588f73da672d9bfacd 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

⚠️ @yukikimmura This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Dec 4, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2023

Webrevs

@yukikimmura
Copy link
Author

/approval request I would like to backport this issue to 21u,
because the test dose not work as intended on some Windows environment,
and it always fails in regression testing, resulting in extra costs for checking the test results,
The fix applies cleanly to 21,
There is no risk because the fix is the same as JDK22, and I verified the fix enough,
Testing:I tested BootClassPathTest on Windows(English,Japanese) and Linux(locales used in the test with LANG/LC_ALL/LC_CTYPE).

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@yukikimmura
8318410: The approval request has been created successfully.

@yukikimmura
Copy link
Author

Hello everyone,

Could someone please review this PR?
I would appreciate if you could support this fix.

Thanks,
Kimura Yukihiro

@shipilev
Copy link
Member

This is a clean backport (note clean tag), so we really need to wait for maintainer approval. Severin was just voted in as the jdk21u maintainer, and I expect the approvals would get going again soon.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

@yukikimmura Please move this PR to jdk21u-dev where 21.0.3 development happens. Then close this one. Thanks!

@openjdk openjdk bot added approval and removed approval labels Dec 14, 2023
@yukikimmura
Copy link
Author

Thank you for your advice.
I moved this PR to jdk21u-dev. I will close this PR.

Thanks,
Kimura Yukihiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants