-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows #416
Conversation
👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request I would like to backport this issue to 21u, |
@yukikimmura |
Hello everyone, Could someone please review this PR? Thanks, |
This is a clean backport (note |
@yukikimmura Please move this PR to jdk21u-dev where 21.0.3 development happens. Then close this one. Thanks! |
Thank you for your advice. Thanks, |
I would like to backport JDK-8318410 to 21u because the test dose not work as intended.
The fix applies cleanly to 21u.
I tested BootClassPathTest on Windows(English,Japanese) and Linux(locales used in the test with LANG/LC_ALL/LC_CTYPE).
Could someone please review it?
Thanks,
Kimura Yukihiro
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/416/head:pull/416
$ git checkout pull/416
Update a local copy of the PR:
$ git checkout pull/416
$ git pull https://git.openjdk.org/jdk21u.git pull/416/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 416
View PR using the GUI difftool:
$ git pr show -t 416
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/416.diff
Webrev
Link to Webrev Comment