Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314220: Configurable InlineCacheBuffer size #419

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 5, 2023

Clean backport to allow tuning ICBuffer size, important to dodge many ICBufferFull safepoints.

Additional testing:

  • Eyeballing -XX:+TraceICBuffer output on ad-hoc workloads

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314220 needs maintainer approval

Issue

  • JDK-8314220: Configurable InlineCacheBuffer size (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/419/head:pull/419
$ git checkout pull/419

Update a local copy of the PR:
$ git checkout pull/419
$ git pull https://git.openjdk.org/jdk21u.git pull/419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 419

View PR using the GUI difftool:
$ git pr show -t 419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/419.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a40d8d97e84d88d1a65aba81bfc09339be95e427 8314220: Configurable InlineCacheBuffer size Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Dec 5, 2023

/approval request Clean backport to allow tuning ICBuffer size, important to dodge many ICBufferFull safepoints.

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@shipilev
8314220: The approval request has been created successfully.

@shipilev
Copy link
Member Author

Closed in favor of openjdk/jdk21u-dev#6.

@shipilev shipilev closed this Dec 13, 2023
@shipilev shipilev deleted the JDK-8314220-icbuffer-config branch December 13, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
1 participant