Skip to content

8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2#422

Closed
SoniaZaldana wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-SoniaZaldana-c698b45a
Closed

8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2#422
SoniaZaldana wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-SoniaZaldana-c698b45a

Conversation

@SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Dec 8, 2023

Hi all,

This pull request contains a backport of commit c698b45a from the openjdk/jdk repository.

The commit being backported was authored by Sean Mullan on 21 Sep 2023 and was reviewed by Jamil Nimeh.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313229 needs maintainer approval

Issue

  • JDK-8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/422/head:pull/422
$ git checkout pull/422

Update a local copy of the PR:
$ git checkout pull/422
$ git pull https://git.openjdk.org/jdk21u.git pull/422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 422

View PR using the GUI difftool:
$ git pr show -t 422

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/422.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c698b45a7bcb0eedeed979d482f8ab15cf16baaa 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2023

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 11, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 13, 2023

@SoniaZaldana Development for 21.0.3 has now moved to jdk21u-dev. Please open the PR here: https://github.com/openjdk/jdk21u-dev and close this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants