Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320597: RSA signature verification fails on signed data that does not encode params correctly #426

Closed

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 13, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320597 needs maintainer approval

Issue

  • JDK-8320597: RSA signature verification fails on signed data that does not encode params correctly (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/426/head:pull/426
$ git checkout pull/426

Update a local copy of the PR:
$ git checkout pull/426
$ git pull https://git.openjdk.org/jdk21u.git pull/426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 426

View PR using the GUI difftool:
$ git pr show -t 426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/426.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 11e4a925bec3c1f79e03045d48def53188b655e6 8320597: RSA signature verification fails on signed data that does not encode params correctly Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

⚠️ @wangweij This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Dec 13, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320597: RSA signature verification fails on signed data that does not encode params correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 14, 2023
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

Going to push as commit 60b6a66.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2023
@openjdk openjdk bot closed this Dec 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@wangweij Pushed as commit 60b6a66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant