Skip to content

8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries#427

Closed
raviniitw2012 wants to merge 1 commit intoopenjdk:masterfrom
raviniitw2012:JDK-8322883
Closed

8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries#427
raviniitw2012 wants to merge 1 commit intoopenjdk:masterfrom
raviniitw2012:JDK-8322883

Conversation

@raviniitw2012
Copy link
Contributor

@raviniitw2012 raviniitw2012 commented Jan 3, 2024

javac fails with "Unable to implement method" after fixing JDK-8225377 and JDK-8320001 in 21.0.2 . More details in JDK-8322641.

Backing out fix JDK-8225377 and JDK-8320001 from 21.0.2.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8322883 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/427/head:pull/427
$ git checkout pull/427

Update a local copy of the PR:
$ git checkout pull/427
$ git pull https://git.openjdk.org/jdk21u.git pull/427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 427

View PR using the GUI difftool:
$ git pr show -t 427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/427.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back rreddy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@robm-openjdk usage: /approve [<id>] (yes|no)

@robm-openjdk
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@robm-openjdk
8322883: The approval request has been approved.

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backout code looks correct

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

⚠️ @raviniitw2012 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@raviniitw2012 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries

Reviewed-by: coffeys, robm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @robm-openjdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2024
Copy link
Member

@robm-openjdk robm-openjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviniitw2012
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@raviniitw2012
Your change (at version 2645682) is now ready to be sponsored by a Committer.

@robm-openjdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

Going to push as commit 18e97aa.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2024
@openjdk openjdk bot closed this Jan 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@robm-openjdk @raviniitw2012 Pushed as commit 18e97aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants

Comments