Skip to content

8323659: LinkedTransferQueue add and put methods call overridable offer #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Jan 17, 2024

Hi all,

This pull request contains a backport of commit ee4d9aa4 from the openjdk/jdk repository.

The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323659 needs maintainer approval

Issue

  • JDK-8323659: LinkedTransferQueue add and put methods call overridable offer (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/433/head:pull/433
$ git checkout pull/433

Update a local copy of the PR:
$ git checkout pull/433
$ git pull https://git.openjdk.org/jdk21u.git pull/433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 433

View PR using the GUI difftool:
$ git pr show -t 433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/433.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2024

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7 8323659: LinkedTransferQueue add and put methods call overridable offer Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

⚠️ @ChrisHegarty This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2024

Webrevs

@ChrisHegarty
Copy link
Member Author

Closing in favour of a separate PR targeting 21u-dev ( whereas this PR incorrectly targeted 21u )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant