Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322790: RISC-V: Tune costs for shuffles with no conversion #434

Conversation

Ilyagavrilin
Copy link

@Ilyagavrilin Ilyagavrilin commented Jan 30, 2024

Hi all, I would like to backport JDK-8322790 to jdk21u in order to improve performance for methods operating with integer representations of floating point values.
Patch applies clean, backported to jdk22u.


Progress

  • JDK-8322790 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322790: RISC-V: Tune costs for shuffles with no conversion (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/434/head:pull/434
$ git checkout pull/434

Update a local copy of the PR:
$ git checkout pull/434
$ git pull https://git.openjdk.org/jdk21u.git pull/434/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 434

View PR using the GUI difftool:
$ git pr show -t 434

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/434.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2024

👋 Welcome back igavrilin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2acb5bd9924511b58b0e57ea9eb6c2dee9fd3ee8 8322790: RISC-V: Tune costs for shuffles with no conversion Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

⚠️ @Ilyagavrilin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2024

Webrevs

@RealFYang
Copy link
Member

@Ilyagavrilin:Shouldn't this be backported into jdk21u-dev repo first? See [1].

[1] https://wiki.openjdk.org/display/JDKUpdates/JDK+21u

@GoeLin
Copy link
Member

GoeLin commented Feb 7, 2024

Hi @Ilyagavrilin

you need to backport this to jdk21u-dev. This repo here is only for ramp down and delivery. Please close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
3 participants