Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers #436

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Feb 8, 2024

Hi all,

This pull request contains a backport of commit 4cd31875 from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 6 Feb 2024 and was reviewed by Andrew Haley and Nick Gasson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324874 needs maintainer approval

Issue

  • JDK-8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/436/head:pull/436
$ git checkout pull/436

Update a local copy of the PR:
$ git checkout pull/436
$ git pull https://git.openjdk.org/jdk21u.git pull/436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 436

View PR using the GUI difftool:
$ git pr show -t 436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/436.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4cd318756d4a8de64d25fb6512ecba9a008edfa1 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

⚠️ @eastig This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@shipilev
Copy link
Member

shipilev commented Feb 8, 2024

Should be against jdk21u-dev, not jdk21u ;)

@eastig
Copy link
Member Author

eastig commented Feb 8, 2024

Should be against jdk21u-dev, not jdk21u ;)

Oops :(

@eastig eastig closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants