Skip to content

8326974: ODR violation in macroAssembler_aarch64.cpp #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lewurm
Copy link
Member

@lewurm lewurm commented Apr 25, 2024

This pull request contains a backport of commit b972997a from the openjdk/jdk repository.

The commit being backported was authored by Andrew Haley on 1 Mar 2024 and was reviewed by Andrew Dinn, Aleksey Shipilev and Guoxiong Li.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326974 needs maintainer approval

Issue

  • JDK-8326974: ODR violation in macroAssembler_aarch64.cpp (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/446/head:pull/446
$ git checkout pull/446

Update a local copy of the PR:
$ git checkout pull/446
$ git pull https://git.openjdk.org/jdk21u.git pull/446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 446

View PR using the GUI difftool:
$ git pr show -t 446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/446.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b972997af76a506ffd79ee8c6043e7a8db836b33 8326974: ODR violation in macroAssembler_aarch64.cpp Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

⚠️ @lewurm This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

@shipilev
Copy link
Member

The PR should be against https://github.com/openjdk/jdk21u-dev, not https://github.com/openjdk/jdk21u, right? :) Consider closing this one and re-opening against jdk21u-dev.

@lewurm
Copy link
Member Author

lewurm commented Apr 26, 2024

thank you @shipilev, I knew I did something wrong 😅

-> openjdk/jdk21u-dev#534

@lewurm lewurm closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants