Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333462: Performance regression of new DecimalFormat() when compare to jdk11 #447

Closed
wants to merge 1 commit into from

Conversation

lingjun-cg
Copy link
Contributor

@lingjun-cg lingjun-cg commented Jun 11, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333462 needs maintainer approval

Issue

  • JDK-8333462: Performance regression of new DecimalFormat() when compare to jdk11 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/447/head:pull/447
$ git checkout pull/447

Update a local copy of the PR:
$ git checkout pull/447
$ git pull https://git.openjdk.org/jdk21u.git pull/447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 447

View PR using the GUI difftool:
$ git pr show -t 447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/447.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2024

👋 Welcome back lingjun-cg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d826127970bd2ae8bf4cacc3c55634dc5af307c4 8333462: Performance regression of new DecimalFormat() when compare to jdk11 Jun 11, 2024
@openjdk
Copy link

openjdk bot commented Jun 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 11, 2024

⚠️ @lingjun-cg This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Jun 11, 2024

@lingjun-cg This is the wrong repo. This repo is collecting critical fixes for the July update. The proposed bug doesn't qualify. Please close this PR and open a new one at https://github.com/openjdk/jdk21u-dev.

@lingjun-cg lingjun-cg closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants