-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334441: Mark tests in jdk_security_infra group as manual #448
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk. |
@sendaoYan |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the review. |
@sendaoYan Can you please integrate this PR as well as those for jdk17u and jdk11u today because it's the last day before code freeze. Thanks. |
Okey. |
@sendaoYan |
/sponsor |
Thanks for the approved and sponsor. |
Going to push as commit a0b3c6c. |
@RealCLanger @sendaoYan Pushed as commit a0b3c6c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 8e1d2b09 from the openjdk/jdk repository.
The commit being backported was authored by Rajan Halade on 21 Jun 2024 and was reviewed by Christoph Langer and Sean Mullan.
The file
test/jdk/TEST.groups
has a prefixed PR JDK-8257516 cause this backport not clean, and jdk21u repo doesn't have filetest/jdk/security/infra/javax/net/ssl/HttpsURLConnectionTest.java
, other files are backported cleanly.Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/448/head:pull/448
$ git checkout pull/448
Update a local copy of the PR:
$ git checkout pull/448
$ git pull https://git.openjdk.org/jdk21u.git pull/448/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 448
View PR using the GUI difftool:
$ git pr show -t 448
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/448.diff
Webrev
Link to Webrev Comment