Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334441: Mark tests in jdk_security_infra group as manual #448

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 24, 2024

Hi all,

This pull request contains a backport of commit 8e1d2b09 from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 21 Jun 2024 and was reviewed by Christoph Langer and Sean Mullan.

The file test/jdk/TEST.groups has a prefixed PR JDK-8257516 cause this backport not clean, and jdk21u repo doesn't have file test/jdk/security/infra/javax/net/ssl/HttpsURLConnectionTest.java, other files are backported cleanly.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334441 needs maintainer approval

Issue

  • JDK-8334441: Mark tests in jdk_security_infra group as manual (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/448/head:pull/448
$ git checkout pull/448

Update a local copy of the PR:
$ git checkout pull/448
$ git pull https://git.openjdk.org/jdk21u.git pull/448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 448

View PR using the GUI difftool:
$ git pr show -t 448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/448.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334441: Mark tests in jdk_security_infra group as manual

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 8e1d2b091c9a311d98a0b886a803fb18d4405d8a 8334441: Mark tests in jdk_security_infra group as manual Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@sendaoYan
8334441: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 24, 2024
@sendaoYan
Copy link
Member Author

/test

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sendaoYan
Copy link
Member Author

LGTM.

Thanks for the review.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 24, 2024
@RealCLanger
Copy link
Contributor

@sendaoYan Can you please integrate this PR as well as those for jdk17u and jdk11u today because it's the last day before code freeze. Thanks.

@sendaoYan
Copy link
Member Author

@sendaoYan Can you please integrate this PR as well as those for jdk17u and jdk11u today because it's the last day before code freeze. Thanks.

Okey.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@sendaoYan
Your change (at version d7000a7) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@sendaoYan
Copy link
Member Author

Thanks for the approved and sponsor.

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit a0b3c6c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 25, 2024
@sendaoYan sendaoYan deleted the jbs8334441 branch June 25, 2024 03:56
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@RealCLanger @sendaoYan Pushed as commit a0b3c6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants