Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #449

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 30, 2024

A backport to jdk21u as this fixes a jck issue.

I had to remove the namespace from LogConfiguration::StdoutLog as JDK-8299825 is not in 21.
I also had to adapt TestVerboseClassLoading, as 'cause' is not known to the logging in 21.

Tests fail as expected, and passes with the fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338139 needs maintainer approval
  • Change requires CSR request JDK-8338540 to be approved

Issues

  • JDK-8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods (Bug - P1 - Approved)
  • JDK-8338540: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/449/head:pull/449
$ git checkout pull/449

Update a local copy of the PR:
$ git checkout pull/449
$ git pull https://git.openjdk.org/jdk21u.git pull/449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 449

View PR using the GUI difftool:
$ git pr show -t 449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/449.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 30, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 2, 2024

GHA failure: TEST: serviceability/sa/ClhsdbFindPC.java#no-xcomp-process
Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test ERROR java.lang.RuntimeException: '^sun.jvm.hotspot.debugger.DebuggerException:.*$' found in stderr: 'sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process)'

Linkage problem, surely unrelated to my change that does not touch this symbol. Was there some old binary somewhere?
Will trigger retest.

@GoeLin GoeLin changed the title 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Backport 9775d57168695dc0d758e017fe5069d93d593f3e Sep 2, 2024
@openjdk openjdk bot changed the title Backport 9775d57168695dc0d758e017fe5069d93d593f3e 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Sep 2, 2024
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting and your explanations!

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 2, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

Going to push as commit 459757e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2024
@openjdk openjdk bot closed this Sep 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2024
@openjdk
Copy link

openjdk bot commented Sep 3, 2024

@GoeLin Pushed as commit 459757e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8338139 branch September 3, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants