-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #449
Conversation
…ent with their setVerbose methods
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
GHA failure: TEST: serviceability/sa/ClhsdbFindPC.java#no-xcomp-process Linkage problem, surely unrelated to my change that does not touch this symbol. Was there some old binary somewhere? |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for backporting and your explanations!
|
/integrate |
Going to push as commit 459757e. |
A backport to jdk21u as this fixes a jck issue.
I had to remove the namespace from LogConfiguration::StdoutLog as JDK-8299825 is not in 21.
I also had to adapt TestVerboseClassLoading, as 'cause' is not known to the logging in 21.
Tests fail as expected, and passes with the fix.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/449/head:pull/449
$ git checkout pull/449
Update a local copy of the PR:
$ git checkout pull/449
$ git pull https://git.openjdk.org/jdk21u.git pull/449/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 449
View PR using the GUI difftool:
$ git pr show -t 449
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/449.diff
Webrev
Link to Webrev Comment