Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 #453

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 10, 2024

Running one test as /othervm makes sure the lib is not loaded twice in the same VM

Testing:
The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339869 needs maintainer approval

Issue

  • JDK-8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/453/head:pull/453
$ git checkout pull/453

Update a local copy of the PR:
$ git checkout pull/453
$ git pull https://git.openjdk.org/jdk21u.git pull/453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 453

View PR using the GUI difftool:
$ git pr show -t 453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/453.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2024
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@mlbridge
Copy link

mlbridge bot commented Sep 10, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@jerboaa
Copy link
Contributor

jerboaa commented Sep 10, 2024

FWIW, wrong bug in PR title. The JBS issue has it correct.

@GoeLin GoeLin changed the title 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8338884 8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 Sep 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 11, 2024

Thanks! Fixed the bugID.

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 11, 2024

GHA failure: well known ClhsdbFindPC issue, unrelated

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

Going to push as commit 34b4bd4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2024
@openjdk openjdk bot closed this Sep 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 11, 2024
@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@GoeLin Pushed as commit 34b4bd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_8339869 branch September 11, 2024 12:02
@GoeLin GoeLin restored the goetz_8339869 branch September 11, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants