-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8339869: [21u] Test CreationTime.java fails with UnsatisfiedLinkError after 8334339 #453
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
1f22d3c
to
bba647a
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
FWIW, wrong bug in PR title. The JBS issue has it correct. |
Thanks! Fixed the bugID. |
|
GHA failure: well known ClhsdbFindPC issue, unrelated |
/integrate |
Going to push as commit 34b4bd4. |
Running one test as /othervm makes sure the lib is not loaded twice in the same VM
Testing:
The failure was sporadic, but we saw it in our 4 daily test runs (21u, 21u-dev, 17u, 17u-dev) about once a day. Since adding this fix temporary to the four test setups on September 3rd, we have not encountered the problem again.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/453/head:pull/453
$ git checkout pull/453
Update a local copy of the PR:
$ git checkout pull/453
$ git pull https://git.openjdk.org/jdk21u.git pull/453/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 453
View PR using the GUI difftool:
$ git pr show -t 453
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/453.diff
Webrev
Link to Webrev Comment