Skip to content

8316428: G1: Nmethod count statistics only count last code root set iterated#458

Closed
jianglizhou wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jianglizhou-fab372d3-master
Closed

8316428: G1: Nmethod count statistics only count last code root set iterated#458
jianglizhou wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jianglizhou-fab372d3-master

Conversation

@jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented Oct 23, 2024

Auto suggested description:
This pull request contains a backport of commit fab372d3 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 19 Sep 2023 and was reviewed by Ivan Walulya and Albert Mingkun Yang.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8316428 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8316428: G1: Nmethod count statistics only count last code root set iterated (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/458/head:pull/458
$ git checkout pull/458

Update a local copy of the PR:
$ git checkout pull/458
$ git pull https://git.openjdk.org/jdk21u.git pull/458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 458

View PR using the GUI difftool:
$ git pr show -t 458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/458.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2024

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fab372d3a23b17f64ae4306e28bdb0bc511f4912 8316428: G1: Nmethod count statistics only count last code root set iterated Oct 23, 2024
@openjdk
Copy link

openjdk bot commented Oct 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 23, 2024
@openjdk
Copy link

openjdk bot commented Oct 23, 2024

⚠️ @jianglizhou This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Oct 24, 2024

Hi @jianglizhou
please backport this to repo jdk21u-dev. jdk21u is used only for rampdown.
Please close this PR.

@jianglizhou
Copy link
Contributor Author

Done. New PR: openjdk/jdk21u-dev#1096. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants