-
Notifications
You must be signed in to change notification settings - Fork 173
8368308: ISO 4217 Amendment 180 Update #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
|
|
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good to me.
|
/approve yes |
|
@gnu-andrew |
|
FWIW the Cura\u00e7ao to Curaçao change is from JDK-8301991 which replaces all escaped UTF-8 characters in resources with actual UTF-8 characters. I wouldn't recommend backporting it :) |
|
/integrate |
|
Going to push as commit 8c322f5. |
|
Thanks for the reviews! |
I backport this for parity with 21.0.10-oracle.
I had to resolve CurrencyData.properties due to a context difference.
A unicode character was represented differently in the patch and my sources.
This would probably be recognized as clean.
Further I resolved @BugID in test/jdk/java/util/Currency/ValidateISO4217.java
I will try to backport test fixes 8354343, 8354344 to avoid this clash in
future.
Test passes.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/472/head:pull/472$ git checkout pull/472Update a local copy of the PR:
$ git checkout pull/472$ git pull https://git.openjdk.org/jdk21u.git pull/472/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 472View PR using the GUI difftool:
$ git pr show -t 472Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/472.diff
Using Webrev
Link to Webrev Comment