Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 26, 2025

I backport this for parity with 21.0.10-oracle.

I had to resolve CurrencyData.properties due to a context difference.
A unicode character was represented differently in the patch and my sources.
This would probably be recognized as clean.

Further I resolved @BugID in test/jdk/java/util/Currency/ValidateISO4217.java
I will try to backport test fixes 8354343, 8354344 to avoid this clash in
future.

Test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8368308 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368308: ISO 4217 Amendment 180 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/472/head:pull/472
$ git checkout pull/472

Update a local copy of the PR:
$ git checkout pull/472
$ git pull https://git.openjdk.org/jdk21u.git pull/472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 472

View PR using the GUI difftool:
$ git pr show -t 472

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/472.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368308: ISO 4217 Amendment 180 Update

Reviewed-by: sgehwolf, mbaesken, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 85f5bf3f415cc3d44d1618ec574e73f846bb91c4 8368308: ISO 4217 Amendment 180 Update Sep 26, 2025
@openjdk
Copy link

openjdk bot commented Sep 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 26, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 26, 2025

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 26, 2025
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@gnu-andrew
8368308: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 26, 2025
@gnu-andrew
Copy link
Member

FWIW the Cura\u00e7ao to Curaçao change is from JDK-8301991 which replaces all escaped UTF-8 characters in resources with actual UTF-8 characters. I wouldn't recommend backporting it :)

@GoeLin
Copy link
Member Author

GoeLin commented Sep 29, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

Going to push as commit 8c322f5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 29, 2025
@openjdk openjdk bot closed this Sep 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2025
@openjdk
Copy link

openjdk bot commented Sep 29, 2025

@GoeLin Pushed as commit 8c322f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8368308 branch September 29, 2025 06:42
@GoeLin
Copy link
Member Author

GoeLin commented Sep 29, 2025

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants