Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309761: Leak class loader constraints #6

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jul 2, 2023

A clean backport to fix memory leak.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309761: Leak class loader constraints (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/jdk21u.git pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/6.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2023

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8e4e6b056c5ecf731f84a71e4e319d2a27734ec2 8309761: Leak class loader constraints Jul 2, 2023
@openjdk
Copy link

openjdk bot commented Jul 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 2, 2023

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309761: Leak class loader constraints

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 4078fb9: Merge
  • c9111d5: 8310743: assert(reserved_rgn != nullptr) failed: Add committed region, No reserved region found
  • 8d6ef6f: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 205dffe: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader
  • 6de4e8f: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit
  • 6f3f4aa: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
  • 8088bc4: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString
  • bbcabe4: 8310838: Correct range notations in MethodTypeDesc specification
  • 35d592e: 8311186: ProblemList javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java on linux-aarch64
  • 6d2f34f: 8311046: ProblemList gc/z/TestHighUsage.java with Generational ZGC
  • ... and 48 more: https://git.openjdk.org/jdk21u/compare/59c18f14c2ee523d4016f2c9828813e8fb066348...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2023

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@coleenp
Copy link
Contributor

coleenp commented Jul 6, 2023

@zhengyu123 did you want to backport this to 21 or 21u1? It would be better if this was in 21 because it was introduced in 21.

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you didn't see my comment, can you backport this to 21 instead?

@zhengyu123
Copy link
Contributor Author

In case you didn't see my comment, can you backport this to 21 instead?

Sorry, missed early comment. Will backport to 21

@zhengyu123 zhengyu123 closed this Jul 7, 2023
@zhengyu123
Copy link
Contributor Author

Backport to 21 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants