Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314262: GHA: Cut down cross-compilation sysroots deeper #61

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 16, 2023

Clean backport to improve GHA overheads.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314262: GHA: Cut down cross-compilation sysroots deeper (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.org/jdk21u.git pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/61.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 38687f1a3eb7d1c2e8aa43b85509ab7999fe0e40 8314262: GHA: Cut down cross-compilation sysroots deeper Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314262: GHA: Cut down cross-compilation sysroots deeper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • be077e0: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
  • c3eda1c: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match
  • 1e81fa5: 8240567: MethodTooLargeException thrown while creating a jlink image
  • d37d019: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • 9c24db1: Merge
  • 890adb6: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64
  • 8002b3e: 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError
  • c746fc0: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16
  • a073530: 8312814: Compiler crash when template processor type is a captured wildcard
  • 01a5df6: 8313345: SuperWord fails due to CMove without matching Bool pack

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 16, 2023

Webrevs

@shipilev
Copy link
Member Author

Testing is clean. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

Going to push as commit 04adfb3.
Since your change was applied there have been 10 commits pushed to the master branch:

  • be077e0: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
  • c3eda1c: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match
  • 1e81fa5: 8240567: MethodTooLargeException thrown while creating a jlink image
  • d37d019: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • 9c24db1: Merge
  • 890adb6: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64
  • 8002b3e: 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError
  • c746fc0: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16
  • a073530: 8312814: Compiler crash when template processor type is a captured wildcard
  • 01a5df6: 8313345: SuperWord fails due to CMove without matching Bool pack

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2023
@openjdk openjdk bot closed this Aug 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@shipilev Pushed as commit 04adfb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8314262-gha-sysroots-deeper branch August 24, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant