Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors #64

Closed
wants to merge 1 commit into from

Conversation

weibxiao
Copy link
Contributor

@weibxiao weibxiao commented Aug 16, 2023

Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.org/jdk21u.git pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/64.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2023

👋 Welcome back weibxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e56d3bc2dab3d32453b6eda66e8434953c436084 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@weibxiao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9c24db1: Merge
  • 890adb6: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64
  • 8002b3e: 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError
  • c746fc0: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16
  • a073530: 8312814: Compiler crash when template processor type is a captured wildcard
  • 01a5df6: 8313345: SuperWord fails due to CMove without matching Bool pack

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@weibxiao
Copy link
Contributor Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Aug 16, 2023

Webrevs

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@weibxiao
Your change (at version d38f28d) is now ready to be sponsored by a Committer.

@robm-openjdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit d37d019.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 9c24db1: Merge
  • 890adb6: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64
  • 8002b3e: 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError
  • c746fc0: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16
  • a073530: 8312814: Compiler crash when template processor type is a captured wildcard
  • 01a5df6: 8313345: SuperWord fails due to CMove without matching Bool pack

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@robm-openjdk @weibxiao Pushed as commit d37d019.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants