Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314423: Multiple patterns without unnamed variables #69

Closed

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Aug 17, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8314423: Multiple patterns without unnamed variables (Bug - P3)
  • JDK-8314216: Case enumConstant, pattern compilation fails (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/69/head:pull/69
$ git checkout pull/69

Update a local copy of the PR:
$ git checkout pull/69
$ git pull https://git.openjdk.org/jdk21u.git pull/69/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 69

View PR using the GUI difftool:
$ git pr show -t 69

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/69.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 43311930107d1783b742adbe567e9bdbcb55775d 8314423: Multiple patterns without unnamed variables Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314423: Multiple patterns without unnamed variables
8314216: Case enumConstant, pattern compilation fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9d1d5e7: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • 32a1c79: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level
  • 04adfb3: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • be077e0: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
  • c3eda1c: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match
  • 1e81fa5: 8240567: MethodTooLargeException thrown while creating a jlink image

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@biboudis
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@biboudis
Your change (at version 17850bd) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

Going to push as commit 8a09253.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 9d1d5e7: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • 32a1c79: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level
  • 04adfb3: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • be077e0: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
  • c3eda1c: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match
  • 1e81fa5: 8240567: MethodTooLargeException thrown while creating a jlink image

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2023
@openjdk openjdk bot closed this Aug 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@vicente-romero-oracle @biboudis Pushed as commit 8a09253.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants