Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails #74

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 21, 2023

Clean backport to fix the test failure with Shenandoah.

Additional testing:

  • Test fails with Shenandoah without the fix, passes with it

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/74/head:pull/74
$ git checkout pull/74

Update a local copy of the PR:
$ git checkout pull/74
$ git pull https://git.openjdk.org/jdk21u.git pull/74/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 74

View PR using the GUI difftool:
$ git pr show -t 74

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/74.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 812f475bc4ea84225e8bbb0b5a677eed0af864dd 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@shipilev
Copy link
Member Author

Testing is clean. Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit c17b5d7.
Since your change was applied there have been 13 commits pushed to the master branch:

  • f07aa56: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 1c3409b: 8313752: InstanceKlassFlags::print_on doesn't print the flag names
  • d6a4e46: 8310233: Fix THP detection on Linux
  • 3d38c53: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
  • 89aea0d: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
  • e1ef69a: Merge
  • 8792922: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java
  • 334b977: 8302017: Allocate BadPaddingException only if it will be thrown
  • 16fa055: 8313904: [macos] All signing tests which verifies unsigned app images are failing
  • 8a09253: 8314423: Multiple patterns without unnamed variables
  • ... and 3 more: https://git.openjdk.org/jdk21u/compare/be077e0667bfd046862aa7994a61fe36356c9afe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@shipilev Pushed as commit c17b5d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8314501-shenandoah-jmapheap branch August 24, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant