Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar #76

Closed
wants to merge 1 commit into from

Conversation

nibjen
Copy link
Contributor

@nibjen nibjen commented Aug 21, 2023

Clean backport of https://bugs.openjdk.org/browse/JDK-8312489 (e47a84f23dd2608c6f5748093eefe301fb5bf750)


Progress

  • Change requires CSR request JDK-8313216 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar (Enhancement - P3)
  • JDK-8313216: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.org/jdk21u.git pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/76.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back nibjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e47a84f23dd2608c6f5748093eefe301fb5bf750 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

⚠️ @nibjen the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8312489
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@nibjen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

Reviewed-by: hchao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • 6588678: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • 5c84a01: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 5ad0c0c: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 82d7bc5: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)
  • c17b5d7: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
  • f07aa56: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • ... and 12 more: https://git.openjdk.org/jdk21u/compare/be077e0667bfd046862aa7994a61fe36356c9afe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@nibjen
Copy link
Contributor Author

nibjen commented Aug 21, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@nibjen
Your change (at version 818c8f4) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

This shouldn't be merged until https://bugs.openjdk.org/browse/JDK-8312489 has jdk21u-fix-yes. Also, please turn on actions on your fork so testing can be run.

@haimaychao
Copy link

Change looks good. Thanks.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

Going to push as commit c7cff81.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 071ec8d: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 511224a: 8313262: C2: Sinking node may cause required cast to be dropped
  • 42aec91: 8313874: JNI NewWeakGlobalRef throws exception for null arg
  • c189275: 8313678: SymbolTable can leak Symbols during cleanup
  • af9d11e: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores
  • 77b5fa2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • 8bf3ba3: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch.
  • 2408df2: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • 1f5ba7a: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 34e9be5: 8312620: WSL Linux build crashes after JDK-8310233
  • ... and 31 more: https://git.openjdk.org/jdk21u/compare/be077e0667bfd046862aa7994a61fe36356c9afe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2023
@openjdk openjdk bot closed this Aug 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@TheRealMDoerr @nibjen Pushed as commit c7cff81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants