Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) #77

Conversation

backwaterred
Copy link

@backwaterred backwaterred commented Aug 21, 2023

Hi all,

This pull request contains a backport of commit fdac6a6a from the openjdk/jdk repository. I am backporting this in order to backport it's follow up as well.

The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.org/jdk21u.git pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/77.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fdac6a6ac871366614efe44aca58ab520766b5c8 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 3d38c53: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
  • 89aea0d: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
  • e1ef69a: Merge
  • 8792922: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java
  • 334b977: 8302017: Allocate BadPaddingException only if it will be thrown
  • 16fa055: 8313904: [macos] All signing tests which verifies unsigned app images are failing
  • 8a09253: 8314423: Multiple patterns without unnamed variables
  • 9d1d5e7: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • 32a1c79: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level
  • 04adfb3: 8314262: GHA: Cut down cross-compilation sysroots deeper

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@backwaterred
Copy link
Author

Approval received!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@backwaterred
Your change (at version 6896e33) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit 82d7bc5.
Since your change was applied there have been 14 commits pushed to the master branch:

  • c17b5d7: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
  • f07aa56: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 1c3409b: 8313752: InstanceKlassFlags::print_on doesn't print the flag names
  • d6a4e46: 8310233: Fix THP detection on Linux
  • 3d38c53: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
  • 89aea0d: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
  • e1ef69a: Merge
  • 8792922: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java
  • 334b977: 8302017: Allocate BadPaddingException only if it will be thrown
  • 16fa055: 8313904: [macos] All signing tests which verifies unsigned app images are failing
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/be077e0667bfd046862aa7994a61fe36356c9afe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@shipilev @backwaterred Pushed as commit 82d7bc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants