Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) #82

Closed

Conversation

backwaterred
Copy link

@backwaterred backwaterred commented Aug 22, 2023

Hi all,

This pull request contains a backport of commit fdac6a6a from the openjdk/jdk repository. It fixes TestByteBuffer.java, and depends on changes the backported by #77.

The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/82/head:pull/82
$ git checkout pull/82

Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.org/jdk21u.git pull/82/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 82

View PR using the GUI difftool:
$ git pr show -t 82

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/82.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2023

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 395fc78880a91eeb06a08c1abf6905d580a650c0 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 3f889a8: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 4909911: 8314960: Add Certigna Root CA - 2
  • f5eef20: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • 46ce555: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • b96aa3c: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • c849fa5: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 4729fad: 8313312: Add missing classpath exception copyright header

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2023

Webrevs

@backwaterred
Copy link
Author

Approval granted.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 27, 2023
@openjdk
Copy link

openjdk bot commented Aug 27, 2023

@backwaterred
Your change (at version 090829d) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

Going to push as commit 2408df2.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 1f5ba7a: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 34e9be5: 8312620: WSL Linux build crashes after JDK-8310233
  • 4cca633: 8312182: THPs cause huge RSS due to thread start timing issue
  • 89234bc: 8303815: Improve Metaspace test speed
  • 3f889a8: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 4909911: 8314960: Add Certigna Root CA - 2
  • f5eef20: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • 46ce555: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • b96aa3c: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • ... and 2 more: https://git.openjdk.org/jdk21u/compare/7a2aa866800296be1b35b4490d9a807fcfe45e91...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2023
@openjdk openjdk bot closed this Aug 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@TheRealMDoerr @backwaterred Pushed as commit 2408df2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants