Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out #83

Closed

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 23, 2023

Hi all,

This pull request contains a backport of commit f142470d from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 14 Aug 2023 and was reviewed by Stefan Karlsson, Patricio Chilano Mateo, Daniel D. Daugherty and Robbin Ehn.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.org/jdk21u.git pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/83.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f142470deaebbf9cff7f6f28842972393506b7c4 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

@dholmes-ora
Copy link
Member Author

Backport has been approved.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

Going to push as commit 3d38c53.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 89aea0d: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2023
@openjdk openjdk bot closed this Aug 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@dholmes-ora Pushed as commit 3d38c53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant