Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313626: C2 crash due to unexpected exception control flow #92

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 23, 2023

Backport of JDK-8313626. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313626: C2 crash due to unexpected exception control flow (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/92/head:pull/92
$ git checkout pull/92

Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.org/jdk21u.git pull/92/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 92

View PR using the GUI difftool:
$ git pr show -t 92

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/92.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f8203cb272e6136b784e5c43a500f6a0bfb19c8b 8313626: C2 crash due to unexpected exception control flow Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313626: C2 crash due to unexpected exception control flow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

Going to push as commit 233076e.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 33ce611: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 5589b9e: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • 5cd6929: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701
  • 70c05d1: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
  • d55535d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
  • bb1adb1: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • c7cff81: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 071ec8d: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 511224a: 8313262: C2: Sinking node may cause required cast to be dropped
  • 42aec91: 8313874: JNI NewWeakGlobalRef throws exception for null arg
  • ... and 29 more: https://git.openjdk.org/jdk21u/compare/89aea0dace4afd2b1bbc5d636322969afcf0072c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2023
@openjdk openjdk bot closed this Sep 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@TobiHartmann Pushed as commit 233076e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants