Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154 #93

Closed

Conversation

valeriepeng
Copy link

@valeriepeng valeriepeng commented Aug 23, 2023

Hi all,

This pull request contains a backport of commit [ba6cdbe2](https://github.com/openjdk/jdk/commit/ba6cdbe2c2897a0fdc266119f0fe4545c3352b8e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Valerie Peng on 22 Aug 2023 and was reviewed by Matthias Baesken and Jamil Nimeh.

Thanks!

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/93/head:pull/93
$ git checkout pull/93

Update a local copy of the PR:
$ git checkout pull/93
$ git pull https://git.openjdk.org/jdk21u.git pull/93/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 93

View PR using the GUI difftool:
$ git pr show -t 93

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/93.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ba6cdbe2c2897a0fdc266119f0fe4545c3352b8e 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154 Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

@valeriepeng
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit c849fa5.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • 6588678: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • 5c84a01: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 5ad0c0c: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 82d7bc5: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)
  • c17b5d7: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
  • f07aa56: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • ... and 3 more: https://git.openjdk.org/jdk21u/compare/89aea0dace4afd2b1bbc5d636322969afcf0072c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@valeriepeng Pushed as commit c849fa5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant