Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer #94

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Aug 23, 2023

Backport JDK-8313796 to 21u to fix a sigsegv. Change is clean and passes tier1 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/jdk21u.git pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/94.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • c849fa5: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • 6588678: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • 5c84a01: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 5ad0c0c: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 82d7bc5: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/89aea0dace4afd2b1bbc5d636322969afcf0072c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@benty-amzn
Your change (at version 58cdee5) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit 46ce555.
Since your change was applied there have been 16 commits pushed to the master branch:

  • b96aa3c: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • c849fa5: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • 6588678: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • 5c84a01: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 5ad0c0c: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • ... and 6 more: https://git.openjdk.org/jdk21u/compare/89aea0dace4afd2b1bbc5d636322969afcf0072c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@phohensee @benty-amzn Pushed as commit 46ce555.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants