Skip to content

8312394: [linux] SIGSEGV if kernel was built without hugepage support #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 24, 2023

Hi all,

This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue").

This particular patch fixes an issue where the JVM would crash on startup when started on a linux box with a kernel that does not support hugepages (mostly affected by this are small SBCs)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312394: [linux] SIGSEGV if kernel was built without hugepage support (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/97/head:pull/97
$ git checkout pull/97

Update a local copy of the PR:
$ git checkout pull/97
$ git pull https://git.openjdk.org/jdk21u.git pull/97/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 97

View PR using the GUI difftool:
$ git pr show -t 97

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/97.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 94eb44b192ba421692549a178c386ea34164ea50 8312394: [linux] SIGSEGV if kernel was built without hugepage support Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312394: [linux] SIGSEGV if kernel was built without hugepage support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 82d7bc5: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)
  • c17b5d7: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
  • f07aa56: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 1c3409b: 8313752: InstanceKlassFlags::print_on doesn't print the flag names

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Aug 26, 2023

Tests clean, apart from riscv, which is an infrastructure issue. Got approval.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2023

Going to push as commit 3f889a8.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 4909911: 8314960: Add Certigna Root CA - 2
  • f5eef20: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • 46ce555: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • b96aa3c: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • c849fa5: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • ... and 7 more: https://git.openjdk.org/jdk21u/compare/d6a4e469e4b2bba2f699d36c7b04aa0381a72c42...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2023
@openjdk openjdk bot closed this Aug 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2023
@openjdk
Copy link

openjdk bot commented Aug 26, 2023

@tstuefe Pushed as commit 3f889a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant