Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8325001: Typo in the javadocs for the Arena::ofShared method #100

Closed

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Feb 1, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325001: Typo in the javadocs for the Arena::ofShared method (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/100/head:pull/100
$ git checkout pull/100

Update a local copy of the PR:
$ git checkout pull/100
$ git pull https://git.openjdk.org/jdk22.git pull/100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 100

View PR using the GUI difftool:
$ git pr show -t 100

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/100.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b84f9bb3ee4362bf9daa4fb3905b168f9035336 8325001: Typo in the javadocs for the Arena::ofShared method Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 1, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325001: Typo in the javadocs for the Arena::ofShared method

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 9cc260d: 8324858: [vectorapi] Bounds checking issues when accessing memory segments
  • d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
  • 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
  • ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
  • bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
  • d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
  • 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 8, 2024
@minborg
Copy link
Contributor Author

minborg commented Feb 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

Going to push as commit 6d9a50e.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9cc260d: 8324858: [vectorapi] Bounds checking issues when accessing memory segments
  • d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
  • 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
  • ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
  • bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
  • d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
  • 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2024
@openjdk openjdk bot closed this Feb 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@minborg Pushed as commit 6d9a50e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants