Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322066: Update troff manpages in JDK 22 before RC #104

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Feb 4, 2024

This update drops the "ea" from the version string.

We also propagate the following fixes from the markdown sources to the troff manpage file:

JDK-8322478: Update java manpage for multi-file source-code launcher
JDK-8302233: HSS/LMS: keytool and jarsigner changes
JDK-8318971: Better Error Handling for Jar Tool When Processing Non-existent Files

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322066: Update troff manpages in JDK 22 before RC (Task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/104/head:pull/104
$ git checkout pull/104

Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.org/jdk22.git pull/104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 104

View PR using the GUI difftool:
$ git pr show -t 104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/104.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2024
@openjdk
Copy link

openjdk bot commented Feb 4, 2024

@dholmes-ora The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org net net-dev@openjdk.org compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Feb 4, 2024
@dholmes-ora dholmes-ora changed the title 8322066: Update troff pages in JDK 22 before RC 8322066: Update troff manpages in JDK 22 before RC Feb 4, 2024
@dholmes-ora
Copy link
Member Author

/label remove kulla

@openjdk openjdk bot removed the kulla kulla-dev@openjdk.org label Feb 4, 2024
@openjdk
Copy link

openjdk bot commented Feb 4, 2024

@dholmes-ora
The kulla label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Feb 4, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322066: Update troff manpages in JDK 22 before RC

Reviewed-by: darcy, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2024
@dholmes-ora
Copy link
Member Author

Thanks for the reviews @jddarcy and @irisclark !

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

Going to push as commit ac7a3c0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2024
@openjdk openjdk bot closed this Feb 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@dholmes-ora Pushed as commit ac7a3c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8322066-manpages branch February 6, 2024 04:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org net net-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
3 participants