8324983: Race in CompileBroker::possibly_add_compiler_threads

[dougxc]

Hi all,

This pull request contains a backport of commit 19936526 from the openjdk/jdk repository.

The commit being backported was authored by Tom Rodriguez on 5 Feb 2024 and was reviewed by Vladimir Kozlov, David Holmes and Doug Simon.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324983: Race in CompileBroker::possibly_add_compiler_threads (Bug - P2)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/108/head:pull/108
$ git checkout pull/108

Update a local copy of the PR:
$ git checkout pull/108
$ git pull https://git.openjdk.org/jdk22.git pull/108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 108

View PR using the GUI difftool:
$ git pr show -t 108

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/108.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c5783b7d)

[vnkozlov]

Good.

Was it "clean" backport?

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324983: Race in CompileBroker::possibly_add_compiler_threads

Reviewed-by: kvn, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Was it "clean" backport?

This PR was automatically generated by the /backport Skara command so I believe that means the backport was "clean". Is that right?

[vnkozlov]

Was it "clean" backport?

This PR was automatically generated by the /backport Skara command so I believe that means the backport was "clean". Is that right?

Yes, I missed that it was auto-generated.

[kevinrushforth]

This PR was automatically generated by the /backport Skara command so I believe that means the backport was "clean". Is that right?

Mote to the point, Skara checks all PRs (whether or not generated via the /backport command) and adds the clean label if the backport is clean, which it did in this case. See this comment above.

[dougxc]

Mach5 testing clean. Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit d8dc711.

[openjdk]

@dougxc Pushed as commit d8dc711.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.