Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 #110

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Feb 13, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 (Bug - P1)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.org/jdk22.git pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/110.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 13d9e8ff38536287b82c54bb63bd2d20f65615dc 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added nio nio-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@RogerRiggs This change is no longer ready for integration - check the PR body for details.

Copy link

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for jdk22u, not jdk22

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 13, 2024
Copy link

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for jdk22u, not jdk22

@kevinrushforth
Copy link
Member

@RogerRiggs Since this is deferred out of JDK 22, you need to close this PR and open a new one against jdk22u.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 13, 2024
@kevinrushforth
Copy link
Member

kevinrushforth commented Feb 13, 2024

@AlanBateman You might want to unapprove this PR (go to "Files" and submit a review with "Request Changes")

UPDATE: I see you already did.

@RogerRiggs
Copy link
Contributor Author

The backport was intended to be for jdk22u

@RogerRiggs RogerRiggs closed this Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org nio nio-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants