-
Notifications
You must be signed in to change notification settings - Fork 30
8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 #110
8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 #110
Conversation
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@RogerRiggs The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@RogerRiggs This change is no longer ready for integration - check the PR body for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for jdk22u, not jdk22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for jdk22u, not jdk22
@RogerRiggs Since this is deferred out of JDK 22, you need to close this PR and open a new one against jdk22u. |
@AlanBateman You might want to unapprove this PR (go to "Files" and submit a review with "Request Changes") UPDATE: I see you already did. |
The backport was intended to be for jdk22u |
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/110/head:pull/110
$ git checkout pull/110
Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.org/jdk22.git pull/110/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 110
View PR using the GUI difftool:
$ git pr show -t 110
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/110.diff
Webrev
Link to Webrev Comment