Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Conversation

@voitylov
Copy link

@voitylov voitylov commented Dec 18, 2023

Hi all,

This pull request contains a backport of commit f573f6d2 from the openjdk/jdk repository.

The commit being backported was authored by Aleksei Voitylov on 13 Dec 2023 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321515: ARM32: Move method resolution information out of the cpCache properly (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/jdk22.git pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/17.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2023

👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f573f6d233d5ea1657018c3c806fee0fac382ac3 8321515: ARM32: Move method resolution information out of the cpCache properly Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@voitylov The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 18, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@voitylov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321515: ARM32: Move method resolution information out of the cpCache properly

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2023
@voitylov
Copy link
Author

/integrate

@voitylov
Copy link
Author

Thank you Aleksey!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@voitylov
Your change (at version d3151e6) is now ready to be sponsored by a Committer.

@dchuyko
Copy link
Member

dchuyko commented Jan 4, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit a6e3565.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a72afb3: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • b8c88a3: 8321599: Data loss in AVX3 Base64 decoding
  • ea6d79f: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • c249229: 8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved
  • fb3cc98: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
  • a05f3d1: 8322041: JDK 22 RDP1 L10n resource files update
  • 3ae97bc: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@dchuyko @voitylov Pushed as commit a6e3565.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants