Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved #19

Closed

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Dec 19, 2023

Clean backport which adds back missing code change in MacroAssembler::load_reserved in file src/hotspot/cpu/riscv/macroAssembler_riscv.cpp for https://bugs.openjdk.org/browse/JDK-8315743. This is a riscv-specific change, risk is low.

  • Run tier1 tests on qemu 8.1.50 with UseRVV (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk22.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/19.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 59073fa3eb7d04d9e0f08fbef70c9db6ffde296a 8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 19, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • fb3cc98: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
  • a05f3d1: 8322041: JDK 22 RDP1 L10n resource files update
  • 3ae97bc: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2023
@zifeihan
Copy link
Member Author

@RealFYang : Thanks for taking a look.
/integrate

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@zifeihan
Your change (at version 2f69ccc) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

Going to push as commit c249229.
Since your change was applied there have been 4 commits pushed to the master branch:

  • fb3cc98: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
  • a05f3d1: 8322041: JDK 22 RDP1 L10n resource files update
  • 3ae97bc: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2023
@openjdk openjdk bot closed this Dec 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@RealFYang @zifeihan Pushed as commit c249229.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants