Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects #20

Closed
wants to merge 1 commit into from

Conversation

fisk
Copy link
Contributor

@fisk fisk commented Dec 19, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects (Bug - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.org/jdk22.git pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/20.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2023

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport be49dabd0d7e1cd270399849e5353bf33361c4c5 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@fisk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 19, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects

Reviewed-by: sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2023
@fisk
Copy link
Contributor Author

fisk commented Dec 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2023

Going to push as commit 3ae97bc.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2023
@openjdk openjdk bot closed this Dec 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@fisk Pushed as commit 3ae97bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants