-
Notifications
You must be signed in to change notification settings - Fork 30
8322041: JDK 22 RDP1 L10n resource files update #22
8322041: JDK 22 RDP1 L10n resource files update #22
Conversation
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@alisenchung The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good. Additionally, I confirmed that the files in question are identical to those in jdk mainline after this patch is applied.
It will need a "R"eviewer to approve.
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit a05f3d1. |
@alisenchung Pushed as commit a05f3d1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8322041
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/22/head:pull/22
$ git checkout pull/22
Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk22.git pull/22/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22
View PR using the GUI difftool:
$ git pr show -t 22
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/22.diff
Webrev
Link to Webrev Comment