Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322041: JDK 22 RDP1 L10n resource files update #22

Closed

Conversation

alisenchung
Copy link

@alisenchung alisenchung commented Dec 20, 2023

Backport of JDK-8322041


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322041: JDK 22 RDP1 L10n resource files update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk22.git pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/22.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2023

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@alisenchung alisenchung changed the title Backport b061b6678fde891974d5b58cec963b3481099a8d 8322047: JDK 22 RDP1 L10n resource files update Dec 20, 2023
@openjdk openjdk bot changed the title 8322047: JDK 22 RDP1 L10n resource files update 8322041: JDK 22 RDP1 L10n resource files update Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@alisenchung The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Dec 20, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good. Additionally, I confirmed that the files in question are identical to those in jdk mainline after this patch is applied.

It will need a "R"eviewer to approve.

@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322041: JDK 22 RDP1 L10n resource files update

Reviewed-by: kcr, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2023
@alisenchung
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2023

Going to push as commit a05f3d1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2023
@openjdk openjdk bot closed this Dec 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@alisenchung Pushed as commit a05f3d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants