Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Conversation

@sspitsyn
Copy link

@sspitsyn sspitsyn commented Dec 20, 2023

Hi all,

This pull request contains a backport of commit 0f8e4e0a from the openjdk/jdk repository.

The commit being backported was authored by Serguei Spitsyn on 19 Dec 2023 and was reviewed by Leonid Mesnik and Alan Bateman.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jdk22.git pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/23.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2023

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0f8e4e0a81257c678e948c341a241dc0b810494f 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@sspitsyn The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • graal
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 20, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2023

Webrevs

@sspitsyn
Copy link
Author

sspitsyn commented Jan 9, 2024

Ping! Need, at list, one review for this 22 backport, please.

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 6b79e79: 8323241: jcmd manpage should use lists for argument lists
  • a8df559: 8321480: ISO 4217 Amendment 176 Update
  • acc4829: 8322725: (tz) Update Timezone Data to 2023d
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • ... and 10 more: https://git.openjdk.org/jdk22/compare/3ae97bc50228b96b7bba66e6d70f07e7357c8160...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2024
@sspitsyn
Copy link
Author

Alan, thank you for review!

@sspitsyn
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

Going to push as commit 865cf88.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2024
@openjdk openjdk bot closed this Jan 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@sspitsyn Pushed as commit 865cf88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport build build-dev@openjdk.org clean core-libs core-libs-dev@openjdk.org graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants