Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8319948: jcmd man page needs to be updated #27

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 4, 2024

Hi all,

This pull request contains a backport of commit 028ec7e from the jdk repository.

The commit being backported was authored by @dholmes-ora on 3 Jan 2024 and was reviewed by @kevinjwalls and @AlanBateman

The backport is not clean as a JDK23 specific change to Compiler.perfmap had to be removed.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319948: jcmd man page needs to be updated (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jdk22.git pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/27.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 028ec7e744f06cd8429b7b74d7b6f7020133aa94 8319948: jcmd man page needs to be updated Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@dholmes-ora The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319948: jcmd man page needs to be updated

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2024
@dholmes-ora
Copy link
Member Author

Thanks for the review @AlanBateman

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit 6aace18.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • 01cb043: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • bb0e203: 8321582: yield .class not parsed correctly.
  • b121931: 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds
  • a6e3565: 8321515: ARM32: Move method resolution information out of the cpCache properly
  • a72afb3: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • b8c88a3: 8321599: Data loss in AVX3 Base64 decoding

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@dholmes-ora Pushed as commit 6aace18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8319948-jcmd branch January 5, 2024 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants