Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index #29

Closed

Conversation

pchilano
Copy link
Contributor

@pchilano pchilano commented Jan 4, 2024

Hi all,

This pull request contains a backport of commit e9e694f4 from the openjdk/jdk repository.

The commit being backported was authored by Patricio Chilano Mateo on 2 Jan 2024 and was reviewed by Dean Long and Frederic Parain.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jdk22.git pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/29.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back pchilanomate! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e9e694f4ef7b080d7fe1ad5b2f2daa2fccd0456e 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@pchilano The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 4, 2024
@pchilano pchilano marked this pull request as ready for review January 4, 2024 19:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@pchilano This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a6e3565: 8321515: ARM32: Move method resolution information out of the cpCache properly
  • a72afb3: 8322647: Short name for the Europe/Lisbon time zone is incorrect

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2024
@pchilano
Copy link
Contributor Author

pchilano commented Jan 5, 2024

Thanks David!

@pchilano
Copy link
Contributor Author

pchilano commented Jan 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit 01cb043.
Since your change was applied there have been 4 commits pushed to the master branch:

  • bb0e203: 8321582: yield .class not parsed correctly.
  • b121931: 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds
  • a6e3565: 8321515: ARM32: Move method resolution information out of the cpCache properly
  • a72afb3: 8322647: Short name for the Europe/Lisbon time zone is incorrect

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@pchilano Pushed as commit 01cb043.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants